Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sending to stealth address (command, grpc, gui) #4307

Merged
merged 5 commits into from
Jul 20, 2022
Merged

feat: add sending to stealth address (command, grpc, gui) #4307

merged 5 commits into from
Jul 20, 2022

Conversation

Cifko
Copy link
Contributor

@Cifko Cifko commented Jul 14, 2022 •
edited by stringhandler
Loading

No description provided.

@Cifko Cifko force-pushed the send-to-stealth branch 2 times, most recently from 08e1c19 to 479e3ff Compare July 18, 2022 07:10
@Cifko Cifko changed the title WIP feat: add sending to stealth address (command, grpc, gui). feat: add sending to stealth address (command, grpc, gui). Jul 18, 2022
@Cifko Cifko changed the title feat: add sending to stealth address (command, grpc, gui). feat: add sending to stealth address (command, grpc, gui) Jul 18, 2022
agubarev added a commit to agubarev/tari that referenced this pull request Jul 18, 2022
@agubarev
merged in tari-project#4307
d27e1b0 
Signed-off-by: Andrei Gubarev <agubarev@users.noreply.github.com>
@Cifko Cifko marked this pull request as ready for review July 18, 2022 15:19
@stringhandler stringhandler added the CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. label Jul 20, 2022
stringhandler
stringhandler approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@stringhandler stringhandler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nonces should probably be saved to generate payment proofs, but this can be added later

@stringhandler stringhandler added mq-approved and removed CR-insufficient_context Your PRs commit messages don't provide enough context to justify accepting the change. labels Jul 20, 2022
@aviator-app aviator-app bot merged commit a897278 into tari-project:development Jul 20, 2022
@Cifko Cifko deleted the send-to-stealth branch August 8, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stringhandler stringhandler stringhandler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Cifko @stringhandler