fix: remove use of hardcoded value (see issue #4451) #4485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes: #4451. |
SWvheerden
reviewed
Aug 17, 2022
| @@ -91,7 +91,7 @@ impl OnConnect { | |||
| .connectivity | |||
| .ban_peer_until( | |||
| conn.peer_node_id().clone(), | |||
| Duration::from_secs(60 * 60), | |||
| Duration::from_secs(DURATION_SYNC_PEERS), | |||
There was a problem hiding this comment.
Dont make it a const, take it from the config, there is a config settings, ban_short_duration
There was a problem hiding this comment.
Great! I add this config value. Much better now :)
SWvheerden
requested changes
Aug 17, 2022
|
Remove |
sdbondi
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
--- Remove the use of hard-coded value here.
Motivation and Context
Fixes #4451
How Has This Been Tested?
--- Manually.