fix: ignored consensus tests (see issue #4559) #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #4559. |
jorgeantonio21
force-pushed
the
ja_fix_tests
branch
from
0c46783
to
e3630c3
Compare
stringhandler
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We address both (ignored) tests
fn version()andfn sender_offset_public_keyfor consensus encoding,Motivation and Context
The
TransactionInputcanonical hash andTransactionOutputhash currently miss specific fields, namelyversionandspender_offset_public_key. We address this following RFC, and resolve the tests mentioned above.How Has This Been Tested?
Unit tests