Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ignores tests in chain_storage.rs #4559

Closed
SWvheerden opened this issue Aug 29, 2022 · 0 comments
Closed

fix ignores tests in chain_storage.rs #4559

SWvheerden opened this issue Aug 29, 2022 · 0 comments
Assignees
@jorgeantonio21

Comments

@SWvheerden
Copy link
Collaborator

The following two tests are ignored and should be fixed:
fn version()
Test
Is testing malleability in the wrong way for sender_offset_public key. This is not checked by the output_mmr, but by the sender_offset. The test should be updated to reflect this.
@jorgeantonio21 jorgeantonio21 self-assigned this Aug 29, 2022
@jorgeantonio21 jorgeantonio21 mentioned this issue Aug 30, 2022
Merged
stringhandler pushed a commit that referenced this issue Aug 30, 2022
@jorgeantonio21
fix: ignored consensus tests (see issue #4559) (#4571)
397fe67 
Description
---

We address both (ignored) tests `fn version()` and `fn sender_offset_public_key` for consensus encoding,

Motivation and Context
---

The `TransactionInput` canonical hash and `TransactionOutput` hash currently miss specific fields, namely `version` and `spender_offset_public_key`. We address this following [RFC](https://rfc.tari.com/RFC-0121_ConsensusEncoding.html#transaction-input), and resolve the tests mentioned above.

How Has This Been Tested?
--- 

Unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jorgeantonio21 jorgeantonio21

Labels
None yet
Projects
Tari Esme Testnet
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SWvheerden @jorgeantonio21