fix: functional wallet encryption (issue #5007) #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
base_layer/wallet/src/key_manager_service/storage/sqlite_db/key_manager_state.rs
Outdated
Show resolved
Hide resolved
base_layer/wallet/src/key_manager_service/storage/sqlite_db/mod.rs
Outdated
Show resolved
Hide resolved
CjS77
added
P-acks_required
jorgeantonio21
force-pushed
the
ja-pure-functional-encryption
branch
from
0e700cf
to
142f835
Compare
SWvheerden
requested changes
Jan 3, 2023
base_layer/wallet/src/key_manager_service/storage/sqlite_db/mod.rs
Outdated
Show resolved
Hide resolved
base_layer/wallet/src/key_manager_service/storage/sqlite_db/key_manager_state.rs
Show resolved
Hide resolved
base_layer/wallet/src/key_manager_service/storage/sqlite_db/mod.rs
Outdated
Show resolved
Hide resolved
base_layer/wallet/src/output_manager_service/storage/sqlite_db/output_sql.rs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wallet encryption and decryption is now done via pure methods, instead of mutating in place the required fields, see #5007.
Motivation and Context
Address issue #5007.
How Has This Been Tested?
Existing unit tests.