feat: remove unused dependencies #5144
Conversation
| @@ -42,5 +39,5 @@ wasm-bindgen-test = "0.3.28" | |||
|
|
|||
| [features] | |||
| avx2 = ["tari_crypto/simd_backend"] | |||
| js = ["getrandom/js", "js-sys"] | |||
There was a problem hiding this comment.
Might be needed to provide random to JS. Guessing machete might not take this into account
There was a problem hiding this comment.
The wasm tests should fail if this is the case
There was a problem hiding this comment.
I manually tested this with 'cargo build - - all-features' if the wasm build with this then it is it should be fine. I picked up 2 issues with this
There was a problem hiding this comment.
cargo test isn't even compiling on this branch.
anyway, the js feature is needed by the wasm feature right beneath it.
test locally in base_layer/key_manager/ by running make test
https://github.com/tari-project/tari/blob/development/base_layer/key_manager/Makefile#L4
There was a problem hiding this comment.
The Js feature is not removed, its still there. Like you say its used by the wasm feature branch.
This PR only removes "getrandom/js"
There was a problem hiding this comment.
If you look at the CI, the key manager wasm tests all pass.
SWvheerden
force-pushed
the
sw_remove_unused_deps
branch
from
36186e0
to
513af56
Compare
|
Its weird that the cargo test compiles and runs fine locally not on CI |
|
I'm happy |
SWvheerden
force-pushed
the
sw_remove_unused_deps
branch
from
ca9f9af
to
5e0c972
Compare
|
It all green now, |
SWvheerden
force-pushed
the
sw_remove_unused_deps
branch
from
5e0c972
to
edb5d8c
Compare
|
1 can def be a separate PR |
Description
Removed all unused dependencies.
Includes
[package.metadata.cargo-machete]for false positivesHow Has This Been Tested?
Manual, unit tests
Fixes: #5136