fix: fix compile error caused by decimal-rs 0.1.42 #5228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
changed the title
stringhandler
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes compile error caused by breaking change for decimal-rs >=0.1.42
Motivation and Context
decimal-rs removed the Error impl for their error type in 0.1.42 but released this breaking change as a patch.
The thiserror from impl requires that the Error trait be implemented so this PR manually implements From
Causing compile error in tari-project/tari-dan#421worked around this and other issues by not updating all dependencies and locking to 0.47.0-pre.0 tag.How Has This Been Tested?
Code compiles