Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add necessary trait bounds to balanced merkle tree #5232

Conversation

jorgeantonio21
Copy link
Contributor

Description

Introduces necessary trait bounds to the BalancedBinaryMerkleProof struct.

Motivation and Context

In order to update the Tari DAN layer repo to make use of BMTs, we need that the current struct BalancedBinaryMerkleProof derives certain trait bounds, namely #[derive(Clone, PartialEq, Eq, Deserialize, Serialize)].

How Has This Been Tested?

Run cargo build.

Copy link
Collaborator

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The as casts can overflow.

Copy link
Collaborator

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails CI.

AaronFeickert
AaronFeickert previously approved these changes Mar 9, 2023
Copy link
Collaborator

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit, otherwise looks good if CI agrees.

Copy link
Collaborator

@AaronFeickert AaronFeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stringhandler stringhandler merged commit 3b971a3 into tari-project:development Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants