feat!: move key manager service to key_manager #5284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the key_manager_services to key_manager_create
Motivation and Context
Currently, all transactions are built by supplying private keys to the constructor. The wallet implements a Key_manager_service that safely constructs the private key but this is then passed around in code to where it is used to sign transactions etc.
We want to refactor this, that the code only ask for a signature and not a private key. This means the private key generation should happen where core can access it. This will be refactored in a future PR. This is part of allowing support of Hardware devices in the future.
How Has This Been Tested?
Unit tests and manual tx sending
Breaking Changes
Requires data directory to be deleted on the wallet
BREAKING CHANGE: Requires data directory to be deleted on the wallet because it changes how the wallet database structure looks.