Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timelocked outputs should be marked #5289

Closed
CjS77 opened this issue Apr 5, 2023 · 1 comment · Fixed by #5290
Closed

Timelocked outputs should be marked #5289

CjS77 opened this issue Apr 5, 2023 · 1 comment · Fixed by #5290
Labels
A-wallet Area - related to the wallet C-enhancement Category - New feature or request

Comments

@CjS77
Copy link
Collaborator

CjS77 commented Apr 5, 2023

Describe the bug
Timelocked outputs (incl coinbase outputs) are in users' possession but cannot be spent. The wallet accurately reflects this in the balance, but the UTXO list does not indicate as such.

In particular, coinbase transactions are marked as Miner confirmed once they are validated.

It would be better to have their status as
Locked
or even better
Locked until {block number}
@CjS77 CjS77 added C-enhancement Category - New feature or request A-wallet Area - related to the wallet labels Apr 5, 2023
@CjS77
Copy link
Collaborator Author

CjS77 commented Apr 5, 2023

It looks like maturity is displayed, but it falls off the bottom of the screen.
ui/components/transactions_tab.rs:462

Adjusting the window sizes should resolve this.

CjS77 added a commit that referenced this issue Apr 5, 2023
@CjS77
fix: resize transaction tab windows
00828a1 
PR #4942 added a row to the tx detail view, but did not increase the
size of the box. As a result, the maturity is cut off.

This PR makes the detail box one row wider, and adjusts the minimum size
of the tx box to be 8 (this is the absolute minimum -- accounting for
headers and one each of pending and completed txs).

Fixes #5289
@CjS77 CjS77 mentioned this issue Apr 5, 2023
Merged
ghpbot-tari-project pushed a commit that referenced this issue Apr 5, 2023
@CjS77
fix: resize transaction tab windows (#5290)
bd95a85 
PR #4942 added a row to the tx detail view, but did not increase the
size of the box. As a result, the maturity is cut off.

This PR makes the detail box one row wider, and adjusts the minimum size
of the tx box to be 8 (this is the absolute minimum -- accounting for
headers and one each of pending and completed txs).

Fixes #5289

```
Tari Console Wallet────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ Transactions │ Send │ Receive │ Contacts │ Network │ Events │ Log │ Notifications                                                 │
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
┌Balance────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│Available: 0 µT (Time Locked: 0 µT)                              Pending Incoming: 0 µT           Pending Outgoing: 0 µT           │
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
 Up↑/Down↓ select Tx (C) cancel selected pending Txs (A) show/hide mining (R) rebroadcast Txs (Esc) exit list
┌Completed (T)ransactions (0) ──────────────────────────────────────────────────────────────────────────────────────────────────────┐
│   Source/Destination Address                                         Amount/Token      Mined At (Local)    Status                 │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
│                                                                                                                                   │
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
┌Transaction Details────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│TxID:                                                                                                                              │
│Source Address:                                                                                                                    │
│Destination address:                                                                                                               │
│Direction:                                                                                                                         │
│Amount:                                                                                                                            │
│Fee:                                                                                                                               │
│Status:                                                                                                                            │
│Message:                                                                                                                           │
│Mined At (Local):                                                                                                                  │
│Imported At (Local):                                                                                                               │
│Excess:                                                                                                                            │
│Confirmations:                                                                                                                     │
│Mined Height:                                                                                                                      │
│Maturity:                                                                                                                          │
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘
 Base Node Status  -  Chain Tip: #12365  Synced.  Latency 562 ms                  Connected Base Node ID: 99999903f5951fa1ca9505c3c2
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 Network: stagenet         Version: 0.49.0-pre.5     LeftArrow: Previous Tab  Tab/RightArrow: Next Tab              F10/Ctrl-Q: Quit
 ```
@SWvheerden SWvheerden mentioned this issue Apr 5, 2023
Merged
SWvheerden added a commit that referenced this issue Apr 5, 2023
@SWvheerden
chore(version): v0.49.0-pre.6 (#5292)
b6a93ee 
##
[0.49.0-pre.6](v0.49.0-pre.5...v0.49.0-pre.6)
(2023-04-05)


### ⚠ BREAKING CHANGES

* move key manager service to key_manager (5284)
* add igor faucet (5281)
* reset dates for networks (5283)

### Features

* add igor faucet
([5281](#5281))
([bfc92fd](bfc92fd))
* added auxiliary callback to push base node state changes
[5109](#5109)
([#5257](#5257))
([b7f7d31](b7f7d31))
* move key manager service to key_manager
([5284](#5284))
([d50ed02](d50ed02))
* reset dates for networks
([5283](#5283))
([d6342a4](d6342a4))


### Bug Fixes

* resize transaction tab windows
([5290](#5290))
([bd95a85](bd95a85)),
closes [#4942](#4942)
[#5289](#5289)
[#12365](https://github.com/tari-project/tari/issues/12365)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-wallet Area - related to the wallet C-enhancement Category - New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: resize transaction tab windows tari-project/tari
1 participant
@CjS77