Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BP+ rewinding does not work if minimum_value_promise != 0 #5297

Closed
hansieodendaal opened this issue Apr 6, 2023 · 1 comment
Closed

BP+ rewinding does not work if minimum_value_promise != 0 #5297

hansieodendaal opened this issue Apr 6, 2023 · 1 comment
Assignees
@hansieodendaal

Comments

@hansieodendaal
Copy link
Contributor

hansieodendaal commented Apr 6, 2023 •
edited
Loading

transaction_output.rs::pub fn recover_mask() should call prover.recover_extended_mask() instead of prover.recover_mask()
@hansieodendaal hansieodendaal mentioned this issue Apr 11, 2023
Merged
4 tasks
SWvheerden pushed a commit that referenced this issue Apr 11, 2023
@hansieodendaal
feat: add extended mask recovery (#5301)
23d882e 
Description
---
Added extended mask recovery where the proof may contain a minimum value
promise > 0

Motivation and Context
---
See [#5297](#5297)

How Has This Been Tested?
---

What process can a PR reviewer use to test or verify this change?
---
Unit test `fn test_output_rewinding_bulletproofs()` expanded to cater
for mask recovery with minimum value promise > 0

Breaking Changes
---

- [x] None
- [ ] Requires data directory on base node to be deleted
- [ ] Requires hard fork
- [ ] Other - Please specify

<!-- Does this include a breaking change? If so, include this line as a
footer -->
<!-- BREAKING CHANGE: Description what the user should do, e.g. delete a
database, resync the chain -->
@SWvheerden
Copy link
Collaborator

Fixed in: #5301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hansieodendaal hansieodendaal

Labels
None yet
Projects
Tari Esme Testnet
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SWvheerden @hansieodendaal