Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no book subdir #159

Merged
merged 2 commits into from Mar 12, 2019
Merged

Fix no book subdir #159

merged 2 commits into from Mar 12, 2019

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Mar 12, 2019

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch
  • I ran cargo-fmt --all before pushing
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@sdbondi sdbondi added the review label Mar 12, 2019
CjS77
CjS77 approved these changes Mar 12, 2019
View reviewed changes
Copy link
Collaborator

@CjS77 CjS77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CjS77 CjS77 merged commit d0b9a34 into tari-project:development Mar 12, 2019
@CjS77 CjS77 removed the review label Mar 12, 2019
@sdbondi sdbondi deleted the sb/no-book-subdir branch March 12, 2019 11:59
CjS77 pushed a commit that referenced this pull request Jun 14, 2022
@tomaszantas
Add Running button (#159)
7f9c950
CjS77 pushed a commit that referenced this pull request Jun 14, 2022
@tomaszantas @CjS77
Add Running button (#159)
8075d31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CjS77 CjS77 CjS77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sdbondi @CjS77