Update sending of Tx Reply & Finalise msgs to send via Store and Forward only if Direct fails #1876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipr-za
changed the title
This PR updates the Transaction Service to first attempt to send the Transaction Reply and Transaction Finalise message Directly and only if that process fails to send the messages via SAF. Previously, both these message with sent in a Fire and Forget manner where both would be sent simultaneously without feedback. Logging has also been introduced for both these processes.
philipr-za
force-pushed
the
philip-update-tx-reply-finalize
branch
from
0a77747
to
3f9338e
Compare
12 tasks
| .await | ||
| { | ||
| None => { | ||
| self.send_transaction_reply_store_and_forward(tx_id, source_pubkey.clone(), proto_message.clone()) |
There was a problem hiding this comment.
Suggested change
| self.send_transaction_reply_store_and_forward(tx_id, source_pubkey.clone(), proto_message.clone()) | |
| debug!( | |
| target: LOG_TARGET, | |
| "Transaction Reply (TxId: {}) Direct Send to {} not possible, attempting Store and Forward", | |
| tx_id, | |
| source_pubkey, | |
| ); | |
| self.send_transaction_reply_store_and_forward(tx_id, source_pubkey.clone(), proto_message.clone()) |
| } else { | ||
| error!( | ||
| target: LOG_TARGET, | ||
| "Transaction Reply message Send Direct for TxID: {} failed", tx_id |
There was a problem hiding this comment.
Suggested change
| "Transaction Reply message Send Direct for TxID: {} failed", tx_id | |
| "Transaction Reply message Send Direct for TxID: {} failed, attempting Store and Forward", tx_id |
| error!( | ||
| target: LOG_TARGET, | ||
| "Direct Send of Transaction Reply message for TX_ID: {} was unsuccessful and no \ | ||
| message was sent", |
There was a problem hiding this comment.
Suggested change
| message was sent", | |
| message was sent, attempting Store and Forward", |
| true => { | ||
| info!( | ||
| target: LOG_TARGET, | ||
| "Direct Send of Transaction Finalized message for TX_ID: {} was successful", |
There was a problem hiding this comment.
Suggested change
| "Direct Send of Transaction Finalized message for TX_ID: {} was successful", | |
| "Direct Send of Transaction Finalized message for TX_ID: {} was successful ({:?})", |
| info!( | ||
| target: LOG_TARGET, | ||
| "Direct Send of Transaction Finalized message for TX_ID: {} was successful", | ||
| self.id |
There was a problem hiding this comment.
Suggested change
| self.id | |
| self.id, | |
| send_states[0].tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Transaction Service to first attempt to send the Transaction Reply and Transaction Finalise message Directly and only if that process fails to send the messages via SAF. Previously, both these message with sent in a Fire and Forget manner where both would be sent simultaneously without feedback.
Logging has also been introduced for both these processes.
How Has This Been Tested?
Test provided that uses the Mock Outbound Messaging Service to test that if Direct sending succeeds that SAF is not sent but if Direct sending fails then SAF is sent for both message types.
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.