Chain metadata service not updating metadata on reorgs #1890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data that it distributes to remote nodes. It should keep this copy uptodate with the blockchain db based on received BlockEvents. It only updated the metadata on block add events and not reorg events, this could have resulted in outdated metadata being shared on the network. - Fixed an issue with the chain metadata service where it was not updating its copy of the chain metadata on reorg events. This could have resulted in some nodes on the network reporting outdated chain metadata. - The chain metadata service will look for both block add and reorg events to determine if the blockchain db state was updated and the latest chain metadata needs to be retrieved. - Also, chained the max send retries used by the Message protocol to 1.
neonknight64
force-pushed
the
yuko-chainmetadata_service_update
branch
from
504d087
to
bb3ada5
Compare
sdbondi
approved these changes
May 20, 2020
| @@ -42,4 +42,4 @@ pub const MESSAGING_EVENTS_BUFFER_SIZE: usize = 100; | |||
| pub const MESSAGING_REQUEST_BUFFER_SIZE: usize = 50; | |||
| /// The default maximum number of times to retry sending a failed message before publishing a SendMessageFailed event. | |||
| /// This can be low because dialing a peer is already attempted a number of times. | |||
| pub const MESSAGING_MAX_SEND_RETRIES: usize = 2; | |||
| pub const MESSAGING_MAX_SEND_RETRIES: usize = 1; | |||
There was a problem hiding this comment.
Might need to watch this for wallets, but agree with this in general. Good to see that tests pass, seems to indicate this retry (originally in response to test flakiness) might not be needed at all!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-Also, chained the max send retries used by the Message protocol to 1.
Motivation and Context
The chain metadata service keeps an internal copy of the chain metadata that it distributes to remote nodes. It should keep this copy uptodate with the blockchain db based on received BlockEvents. It only updated the metadata on block add events and not reorg events, this could have resulted in outdated metadata being shared on the network.
How Has This Been Tested?
Existing tests remain functioning.
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.