Input and output previous STXO block validation check #1974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a full consensus block validation check that ensures that the inputs and outputs are not part of the STXO set. This duplicate hash check should be performed to ensure that when a block is added to the blockchain backend that it does not leave the backend in an inconsistent state.
I synced my base node from scratch and these changes do not seem to be consensus breaking.
Motivation and Context
As key value stores are used in the blockchain backend, adding of duplicate hashes can cause the backend to be in an inconsistent state.
How Has This Been Tested?
Code similar to transaction validation check, no tests were added.
Types of changes
Checklist:
development
branch.cargo-fmt --all
before pushing.