Base node block sync RPC service #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
sb-core-base-node-rpc
branch
4 times, most recently
from
8b9f92b
to
7978ce2
Compare
sdbondi
force-pushed
the
sb-core-base-node-rpc
branch
5 times, most recently
from
fbed41c
to
690286a
Compare
philipr-za
previously approved these changes
Oct 19, 2020
base_layer/core/src/base_node/service/blockchain_state/service.rs
Outdated
Show resolved
Hide resolved
sdbondi
force-pushed
the
sb-core-base-node-rpc
branch
6 times, most recently
from
78cf393
to
9badeaf
Compare
RPC service for faster block sync. Allows streaming of full blocks, headers and a method for chain split detection. The client-side is next up. - Added BlockchainStateService. This service should eventually be the only service which provides a query interface to the blockchain database for other services. - Added BaseNodeSyncRpcService. This RPC service exposes `sync_blocks`, `sync_headers`, `get_header_by_height` and `find_chain_split`. These functions will be used in the improved block sync. - Added `NotFound` status to RpcStatus - Added `RpcStatus::log_internal_error()` convenience function to make dealing with misc errors in RPC handler functions easier. - Added `spawn_until_shutdown` method to the service initialiser context that spawns a task until the shutdown is triggered. This removes the need for implementers to worry about how to implement shutdown in initialisers. - Cleaned up some test helpers - Added unit tests for the Base node sync RPC handlers - Added unit tests for the BlockchainStateService Ref tari-project#2113
sdbondi
force-pushed
the
sb-core-base-node-rpc
branch
from
9badeaf
to
eda40f4
Compare
stringhandler
approved these changes
Oct 26, 2020
This was referenced Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RPC service for faster block sync. Allows streaming of full blocks,
headers and a method for chain split detection. The client-side is next
up.
which provides a query interface to the blockchain database for other
services.
sync_blocks,sync_headers,fetch_header_by_heightandfind_chain_split. Thesefunctions will be used in the improved block sync.
NotFoundstatus to RpcStatusRpcStatus::log_internal_error()convenience function to makedealing with misc errors in RPC handler functions easier.
spawn_until_shutdownmethod to the service initialiser contextthat spawns a task until the shutdown is triggered. This removes the need for
implementers to worry about how to implement shutdown in initialisers.
tokio-testdependencyMotivation and Context
Described here: #2197 (comment)
Ref #2113
How Has This Been Tested?
Extensive unit tests
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.cargo testsuccessfully before submitting my PR.