Fix transaction service bug with tx send/receive cancellation #2354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where the result of the cancellation oneshot in the send and receive protocols was not checked if it was Ok(()). This meant that on a shutdown when the sender side of that oneshot channel is dropped the receiver side resolves to a Err(_) and triggered an attempt to cancel the transaction. Generally the database was already broken down during the shutdown but depending on when stuff is dropped this could mistakenly cancel a pending transaction on wallet shutdown.
philipr-za
force-pushed
the
philip-fix-oneshot-bug
branch
from
0dc0a00
to
84017c4
Compare
|
Nice catch - is there any test we could add for this? |
delta1
approved these changes
Oct 20, 2020
Couldn't think of a way to test it as the bug occured during shutdown which breaks down all the interfaces you could use to do the test with. |
|
Yeah I figured it was difficult to test this one! Well spotted. |
| self.id, | ||
| TransactionServiceError::TransactionCancelled, | ||
| )); | ||
| result = cancellation_receiver => { |
There was a problem hiding this comment.
We should probably log the result via warn! if it's not ok().
There was a problem hiding this comment.
This can only happen if the other end of the channel is shutdown in which case all the channels in this select! will do the same and didn't feel like it needs to be logged as it will happen only in shutdown or else all the channels will show the same error (which are logged).
stringhandler
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug where the result of the cancellation oneshot in the send and receive protocols was not checked if it was Ok(()). This meant that on a shutdown when the sender side of that oneshot channel is dropped the receiver side resolves to a Err(_) and triggered an attempt to cancel the transaction. Generally the database was already broken down during the shutdown but depending on when stuff is dropped this could mistakenly cancel a pending transaction on wallet shutdown.
How Has This Been Tested?
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.cargo testsuccessfully before submitting my PR.