Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for offline connectivity state #2376

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Oct 23, 2020

Description

Connectivity should only be considered Offline if there are zero
connections. Previously, the node could be considered offline if there
if there were no node connections, but some client connections were active.
This PR fixes that.

Motivation and Context

How Has This Been Tested?

Added a new test that fails for this bug

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I ran cargo test successfully before submitting my PR.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Connectivity should only be considered `Offline` if there are zero
connections. Previously, the node could be considered offline if there
if there were no _node_ connections, but some _client_ connections were active.
This PR fixes that.
@sdbondi sdbondi force-pushed the sb-comms-fix-connectivity-offline branch from bbe96d7 to f158050 Compare October 23, 2020 09:14
@stringhandler stringhandler merged commit cd7eb43 into tari-project:development Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants