Fix for network discovery state machine spin loop #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the node is unable to obtain many peers it continues to aggresively ask for peers. On a small localhost network this can cause high CPU usage as it repeatedly queries for peers in a state loop. This fix adds checks in the `Ready` state that allow a transition to `Idle` if: there are no sync peers, there are no sync peers other than the ones used last time, or there have been 10 rounds in a row where the node has not been able to obtain "enough" peers to enter "on connect" mode.
sdbondi
force-pushed
the
sb-dht-network-discovery-fix
branch
from
8e6318b
to
6a8f7eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the node is unable to obtain many peers it continues to aggresively
ask for peers. On a small localhost network this can cause high CPU
usage as it repeatedly queries for peers in a state loop. This fix adds
checks in the
Readystate that allow a transition toIdleif: thereare no sync peers, there are no sync peers other than the ones used last
time, or there have been 10 rounds in a row where the node has not been
able to obtain "enough" peers to enter "on connect" mode.
Motivation and Context
Bug fix
How Has This Been Tested?
Tested on the 2 node network in PR #2358 - CPU usage returns to normal.
Types of changes
Checklist:
developmentbranch.cargo-fmt --allbefore pushing.cargo testsuccessfully before submitting my PR.