Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rincewind from default toml files #2394

Merged

Conversation

SWvheerden
Copy link
Collaborator

Description

Remove rincewind from default toml files

Motivation and Context

Remove rincewind from default toml files to not cause confusion

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I ran cargo test successfully before submitting my PR.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Copy link
Contributor

@philipr-za philipr-za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't directly comment on it but it still references Rincewind on line 1 of tari-sample.toml

Remove all mention of rincewind
@SWvheerden
Copy link
Collaborator Author

I can't directly comment on it but it still references Rincewind on line 1 of tari-sample.toml

Thanks good catch, remove all of them now I think

# rincewind - the Tari test net
network = "rincewind"
# Ridcully - the Tari test net
network = "Ridcully"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
network = "Ridcully"
network = "ridcully"

Not sure if this makes a difference, but probably worth keeping it the same

stringhandler
stringhandler previously approved these changes Oct 27, 2020
stringhandler added a commit that referenced this pull request Oct 27, 2020
Remove rincewind from default toml files
@stringhandler stringhandler merged commit 993be3d into tari-project:development Oct 27, 2020
@SWvheerden SWvheerden deleted the sw_remove_rincewind branch October 28, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants