Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build issues for quay and set tari_crypto back to crates.io #2511

Merged
merged 1 commit into from Jan 6, 2021

Conversation

delta1
Copy link
Contributor

@delta1 delta1 commented Jan 5, 2021

Description

Fixes quay.io docker build for tari_base_node

Motivation and Context

docker image build is broken

How Has This Been Tested?

tested locally and also on quay: https://quay.io/repository/bizzle/tari_base_node/build/40dc3cf6-4548-4aa8-a330-ce631becac27

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature refactor (No new feature or functional changes, but performance or technical debt improvements)
  • New Tests
  • Documentation
  • Devops

Checklist:

  • I'm merging against the development branch.
  • I ran cargo-fmt --all before pushing.
  • I ran cargo test successfully before submitting my PR.
  • I have squashed my commits into a single commit.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@leet4tari
Copy link
Contributor

LGTM

Copy link
Member

@sdbondi sdbondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stringhandler stringhandler merged commit 4c66762 into tari-project:development Jan 6, 2021
stringhandler added a commit that referenced this pull request Jan 22, 2021
Add chain height to list-connections output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants