Fix cucumber tests and add eslint #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice definitely needed |
delta1
reviewed
May 7, 2021
.circleci/config.yml
Outdated
| @@ -92,6 +92,9 @@ commands: | |||
| - run: | |||
| name: Check formatting | |||
| command: cd integration_tests && npm run check-fmt | |||
| - run: | |||
| name: Check eslint | |||
| command: cd integration_tests && npx eslint . | |||
There was a problem hiding this comment.
any reason to not add eslint to package.json with a script there?
There was a problem hiding this comment.
lol, because my js is not great... that is the reason
integration_tests/cucumber.js
Outdated
| }; | ||
| default: '', | ||
| critical: '--format @cucumber/pretty-formatter --tags @critical' | ||
| } |
There was a problem hiding this comment.
I think there's a conflict between prettier and eslint here (single quotes vs double quotes, and semi-colons)
stringhandler
force-pushed
the
mb-fix-cucumber-2
branch
from
092bdb4
to
fb4057f
Compare
- update eslint config to play nicely with prettier - fix lint issues - add husky to run pre-commit hook - add pre-commit hook to run prettier and lint check if files in integration_tests have been staged for commit Tested on macOS and windows
[tests] eslint config and husky pre-commit hook
stringhandler
added a commit
that referenced
this pull request
May 9, 2021
Changes since v0.8.9 Base Node --- - [#2902](#2902) [base-node] Update Base Node Service monitor to shutdown correctly (#2902) - [#2874](#2874) [base-node] Refactor chain storage and rule out some target diff bugs - [#2875](#2875) [base-node] Insert pruned output audit - [#2878](#2878) [base-node] Emission math audit Wallet --- - [#2891](#2891) [wallet] Fixes possible duration overflow in crossterm loop - [#2883](#2883) [wallet] Update connectivity status when base node changes Other --- - [#2900](#2900) [tests] Fix cucumber test (#2900) - [#2888](#2888) [common] Consolidate config files into one - [#2881](#2881) [tests] Add transaction washer util script - [#2879](#2879) [common] Fix potential overflow and improve performance of n_leaves
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
To fix the tests.
Added ESLint to add standards for javascript
How Has This Been Tested?
Checklist:
developmentbranch.