chore: sha2 as dev dependency #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While looking at a [sha2 RUSTSEC advisory](https://rustsec.org/advisories/RUSTSEC-2021-0100.html) (does not apply to Tari) noticed that sha2 is only used in tests so should not be a dependency
stringhandler
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move sha2 to dev dependencies
Motivation and Context
While looking at a sha2 RUSTSEC advisory
(does not apply to Tari) noticed that sha2 is only used in tests so
should not be a dependency
How Has This Been Tested?
Existing tests