Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reset cucumber timeouts to practical limits #3531

Merged
merged 2 commits into from
Nov 8, 2021
Merged

test: reset cucumber timeouts to practical limits #3531

merged 2 commits into from
Nov 8, 2021

Conversation

hansieodendaal
Copy link
Contributor

@hansieodendaal hansieodendaal commented Nov 3, 2021 •
edited
Loading

Description

  • Re-applied reasonable time outs to cucumber tests, using dynamic time-outs in test steps where possible.
  • Fixed a broken test.
  • Fixed some flaky tests.
  • Removed some dead code.
  • Removed duplicate test.

Note: Replaces #3511.

Motivation and Context

  • Tests were flaky on slow and fast computers due to stringent time outs..
  • Some test logic was flawed.
  • Some flaky tests could be improved.

How Has This Been Tested?

Cucumber on slow and fast computers

@hansieodendaal
Reset cucumber timeouts to practical limits
3bb9b0a 
Re-applied reasonable time outs to cucumber tests. It is not worthwhile
to have too stringent time outs as it makes the tests flaky on a slower
system and especially on CI.
philipr-za
philipr-za approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@philipr-za philipr-za left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aviator-app aviator-app bot merged commit 532e509 into tari-project:development Nov 8, 2021
@hansieodendaal hansieodendaal deleted the ho_adjust_cucumber_timeouts branch November 9, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipr-za philipr-za philipr-za approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansieodendaal @philipr-za @stringhandler