Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: console wallet grpc_console_wallet_addresss config #3619

Merged

Conversation

StriderDM
Copy link
Contributor

@StriderDM StriderDM commented Nov 25, 2021

Description

This PR changes grpc_console_wallet_address to grpc_address and moves it into the wallet section of the config.

It also allows a grpc address to be specified via the --grpc-address command line argument for the console_wallet (using standard multiaddr formatting).

Additionally, fixes a bug due to a missing config default.

How Has This Been Tested?

cargo test --all
nvm use 12.22.6 && node_modules/.bin/cucumber-js --profile "ci" --tags "not @long-running and not @broken"
manually (cargo run --bin tari_console_wallet -- --grpc-address /ip4/127.0.0.1/tcp/18144 + bloomRPC client)

@StriderDM StriderDM force-pushed the fix_console_wallet_grpc_config branch 2 times, most recently from 2f08c51 to 60fe449 Compare November 26, 2021 07:33
This PR changes `grpc_console_wallet_address` to `grpc_address` and moves it into the `wallet` section of the config.

Additionally it also allows a grpc address to be specified via the `--grpc-address` command line argument for the console_wallet (using standard multiaddr formatting).

Update cucumber function timeout
@StriderDM StriderDM force-pushed the fix_console_wallet_grpc_config branch from 60fe449 to 333addd Compare November 26, 2021 11:15
@aviator-app aviator-app bot added mq-failed and removed mq-failed labels Nov 26, 2021
@aviator-app aviator-app bot merged commit b09acd1 into tari-project:development Nov 26, 2021
sdbondi added a commit to sdbondi/tari that referenced this pull request Dec 6, 2021
* development: (29 commits)
  fix(pruned mode)!: prune inputs, allow horizon sync resume and other fixes (tari-project#3521)
  feat!: sending one-sided transactions in wallet_ffi (tari-project#3634)
  fix: use json 5 for tor identity (regression) (tari-project#3624)
  test: add operation_id to log messages (tari-project#3633)
  fix!: multiple monerod addresses in tari merge mining proxy (tari-project#3628)
  fix: get-peer command works with public key again (tari-project#3636)
  fix!: separate peer seeds to common.network (tari-project#3635)
  test: removed stress test log target (tari-project#3631)
  feat: removed transaction validation redundant events (tari-project#3630)
  feat: improve wallet responsiveness (tari-project#3625)
  feat: add bulletproof rewind profiling (tari-project#3618)
  fix!: console wallet grpc_console_wallet_addresss config (tari-project#3619)
  test: increase timeout in cucumber (tari-project#3621)
  chore: change status line (tari-project#3610)
  feat!: add tcp bypass settings for tor in wallet_ffi (tari-project#3615)
  feat: only trigger UTXO scanning when a new block event is received (tari-project#3620)
  feat: implement dht pooled db connection (tari-project#3596)
  feat: add page for detailed mempool in explorer (tari-project#3613)
  chore: add pub key in the dailes notify (tari-project#3612)
  feat: display network for console wallet (tari-project#3611)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants