chore!: change hash to use consensus encoding #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hansie Odendaal <39146854+hansieodendaal@users.noreply.github.com>
Co-authored-by: Hansie Odendaal <39146854+hansieodendaal@users.noreply.github.com>
Cifko
changed the title
|
If this breaks sync on the current chain then what purpose does it serve? |
|
We are going to need it if we want to implement any hashing in another language, but for now immediately, it's not required. |
|
Yeah if it requires a chain reset it can't go in now. |
hansieodendaal
added
the
W-consensus_breaking
sdbondi
reviewed
Feb 11, 2022
|
In order for the new hashing to work with the current dibbler chain, we should only use the consensus hashing for block version > 2 |
* development: (54 commits) fix(block-sync): use avg latency to determine slow sync peer for block sync (tari-project#3912) fix: fix merge mining proxy pool mining (tari-project#3814) revert: remove use of blocking tasks for DHT db (reverts tari-project#3887) (tari-project#3901) chore: add license info missing from some crates (tari-project#3892) fix(core): correctly filter pruned sync peers for block sync (tari-project#3902) ci: revert bors squash merge (tari-project#3900) fix: update metadata size calculation to use FixedSet.iter() docs(rfc): deep links structure convention - deep links is use (tari-project#3897) ci: use squash merge for bors (tari-project#3896) change struct fmt chore: fix npm dependencies feat: update FFI client user agent string fix: update wallet logging config fix completed tx index ignore clippy code review fmt fix: add bound for number of console_wallet notifications remove TODOs ...
|
Updated code to continue support for v2 blocks and start using (block template) v3 blocks from height Manually tested syncing from current dibbler |
* development: chore: clean up providing seed words from LibWallet (tari-project#3906) chore: move tari_script into its own crate (tari-project#3909) fix(consensus): check blockchain version within valid range (tari-project#3916) ci: fix missing npm deps and add javascript ci (tari-project#3910) refactor: use clap as a commands parser (tari-project#3867) chore: use git tagged tari_utilities and tari-crypto deps (tari-project#3913) fix: aligned tables left (tari-project#3899) ci: fix vue build v0.29.0 feat!: add recovery byte to output features (tari-project#3727) add ffi ci check (tari-project#3915)
stringhandler
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change hashes to use consensus encoding