Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: gracefully handle recovering a duplicate output in LibWallet #3903

Merged

Commits on Mar 23, 2022

  1. feat: gracefully handle recovering a duplicate output in LibWallet

    This PR addresses the issue of creating duplicate Faux transaction when an output that has previously been recovered is recovered again. This can happen during reorgs.
    It is a small fix to the code that when outputs are scanned to see if they can be rewound only new unique outputs are returned to the caller and duplicate outputs are ignored.
    The UTXO scanner will then only create new Faux transactions for the outputs that have not been previously recovered.
    
    Two Rust tests were added to confirm the correct behaviour in output scanning.
    
    This behaviour was already implemented for One-sided payments and a test existed that tested the ignoring of duplicates.
    philipr-za committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    bd189e0 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'development' into philip-double-import

    Byron Hambly committed Mar 23, 2022
    Configuration menu
    Copy the full SHA
    422045c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b45ba0a View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2022

  1. Configuration menu
    Copy the full SHA
    8f64108 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'development' into philip-double-import

    Byron Hambly committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    efec2d3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a0d2112 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2022

  1. Configuration menu
    Copy the full SHA
    2f08cc0 View commit details
    Browse the repository at this point in the history