Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support safe non-interactive mode #4072

Merged
merged 2 commits into from May 3, 2022
Merged

fix: support safe non-interactive mode #4072

merged 2 commits into from May 3, 2022

Commits on May 3, 2022

  1. fix: support safe non-interactive mode 

    Non-interactive mode should NEVER prompt the user. This PR clears one
path where this happens: If a wallet does not exist and a password has
not been provided so that we can auto-create one. In this case, the
application should just exit.

Providing passwords on the command line is VERY bad practice, since
anyone with access to the machine can see the password in plaintext by
inspecting the running jobs.

The ability to read the password from the commaond-line, OR config file OR envar was
removed in a previous PR, and this is rectified here.
    @CjS77
    CjS77 committed May 3, 2022
    Copy the full SHA
    a43cefc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development' into cjs77_safe_non_interactive_wallet_cre… 

    …ation
    @aviator-app
    aviator-app[bot] committed May 3, 2022
    Copy the full SHA
    3eaee22 View commit details
    Browse the repository at this point in the history