fix: improved encryption key handling #5027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
key-handling-fixes
branch
3 times, most recently
from
ea695fd
to
c0c69ed
Compare
sdbondi
previously approved these changes
Dec 14, 2022
AaronFeickert
force-pushed
the
key-handling-fixes
branch
from
c0c69ed
to
ad862d1
Compare
stringhandler
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves handling of database encryption keys.
Motivation and Context
A recent PR hardens the codebase's handling of encrypted database fields. It stores the derived key used for encryption as a
Zeroizingarray.This work changes the key type to be a
Hiddenwrapper of aSafeArray, which prevents unintended output of the key and tries to prevent copies and moves.How Has This Been Tested?
Existing tests pass.