Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added FFI function wallet_get_network_and_version #5252 #5263

Merged
merged 10 commits into from
Mar 24, 2023
Merged

feat: added FFI function wallet_get_network_and_version #5252 #5263

merged 10 commits into from
Mar 24, 2023

Conversation

agubarev
Copy link
Contributor

Description

  • Network and client APP_VERSION_NUMBER is now stored when wallet is initialized.
  • Added FFI function wallet_get_network_and_version that returns the network and version of the client that has last accessed the wallet database.

Motivation and Context

For debugging purposes on the client (e.g. Mobile)

How Has This Been Tested?

manually

SWvheerden
SWvheerden reviewed Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

base_layer/wallet/src/storage/sqlite_utilities/mod.rs Outdated Show resolved Hide resolved
base_layer/wallet_ffi/src/lib.rs Outdated Show resolved Hide resolved
base_layer/wallet/src/wallet.rs Outdated Show resolved Hide resolved
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Mar 22, 2023
SWvheerden
SWvheerden reviewed Mar 24, 2023
View reviewed changes
base_layer/wallet_ffi/src/lib.rs Outdated Show resolved Hide resolved
base_layer/wallet_ffi/src/lib.rs Outdated Show resolved Hide resolved
SWvheerden
SWvheerden previously approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label Mar 24, 2023
@stringhandler stringhandler added the P-merge Process - Queued for merging label Mar 24, 2023
SWvheerden
SWvheerden reviewed Mar 24, 2023
View reviewed changes
base_layer/wallet_ffi/src/lib.rs Outdated Show resolved Hide resolved
base_layer/wallet_ffi/src/lib.rs Outdated Show resolved Hide resolved
@SWvheerden SWvheerden added this pull request to the merge queue Mar 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2023
@stringhandler stringhandler added this pull request to the merge queue Mar 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 24, 2023
@SWvheerden SWvheerden added this pull request to the merge queue Mar 24, 2023
Merged via the queue into tari-project:development with commit 4b09b59 Mar 24, 2023
SWvheerden added a commit to SWvheerden/tari that referenced this pull request Mar 24, 2023
@SWvheerden
## [0.49.0-pre.4](tari-project/tari@v0.49.0-pre.3...v0.49.0-pre.4) (2…
71853df 
…023-03-24)

### Features

* added FFI function `wallet_get_network_and_version` [tari-project#5252](tari-project#5252) ([tari-project#5263](tari-project#5263)) ([4b09b59](tari-project@4b09b59))
This was referenced Mar 24, 2023
Closed
Merged
SWvheerden added a commit that referenced this pull request Mar 24, 2023
@SWvheerden
chore(version): 0.49.0-pre.4 (#5267)
66286b5 
##
[0.49.0-pre.4](v0.49.0-pre.3...v0.49.0-pre.4)
(2023-03-24)


### Features

* added FFI function `wallet_get_network_and_version`
[5252](#5252)
([#5263](#5263))
([4b09b59](4b09b59))
@brianp brianp mentioned this pull request Jun 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SWvheerden SWvheerden SWvheerden approved these changes

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-merge Process - Queued for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@agubarev @SWvheerden @stringhandler @ghpbot-tari-project