feat!: add claim_public_key to sidechain features #5619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghpbot-tari-project
added
P-acks_required
Test Results (Integration tests) 2 files + 2 11 suites +11 13m 22s ⏱️ + 13m 22s For more details on these failures, see this check. Results for commit 83cb39b. ± Comparison against base commit 45c20a3. ♻️ This comment has been updated with latest results. |
3 tasks
brianp
approved these changes
Aug 9, 2023
ghpbot-tari-project
removed
the
P-reviews_required
|
Yup agree, but the other way round - L2 depends on tari base libs in this repo. In this case it's ok because we reuse the ValidatorNodeSignature abstraction in L2. I would like a library of shared signature types and hash domains, mainly to avoid depending on the whole tari_core crate just for 1/2 hash domains. |
sdbondi
force-pushed
the
core-add-claim-pk-to-vn-reg
branch
from
4e44882
to
83cb39b
Compare
stringhandler
approved these changes
Sep 8, 2023
stringhandler
merged commit 4bdd364
into
tari-project:feature-dan2
13 of 14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add claim public key to validator node registration
Motivation and Context
This claim key is informational and will be used in L2 to restrict fee claims to a particular signing key
How Has This Been Tested?
Existing tests
What process can a PR reviewer use to test or verify this change?
Run register validator node wallet command
Breaking Changes