Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(proto)!: remove proto timestamp wrapper types #5833

Merged
merged 3 commits into from
Oct 23, 2023

Changes for review

e199048
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

refactor(proto)!: remove proto timestamp wrapper types #5833

Changes for review
e199048
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Integration tests) failed Oct 20, 2023 in 0s

1 fail, 32 pass in 12m 56s

  2 files  +  2  11 suites  +11   12m 56s ⏱️ + 12m 56s
33 tests +33  32 ✔️ +32  0 💤 ±0  1 +1 
34 runs  +34  33 ✔️ +33  0 💤 ±0  1 +1 

Results for commit e199048. ± Comparison against earlier commit 4ae725a.

Annotations

Check warning on line 0 in /

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

1 out of 2 runs failed: Scenario: A message receives a delivery receipt via FFI: tests/features/ChatFFI.feature:78:3

artifacts/junit-ffi-cucumber/cucumber-output-junit.xml [took 2s]
Raw output
Step panicked. Captured output: assertion failed: `(left == right)`   left: `1697806717`,  right: `1697806718`
  Scenario: A message receives a delivery receipt via FFI
   ✔  Given I have a seed node SEED_A
   ✔  When I have a chat FFI client CHAT_A connected to seed node SEED_A
   ✔  When I have a chat FFI client CHAT_B connected to seed node SEED_A
   ✔  When I use CHAT_A to send a message 'Hey there' to CHAT_B
   ✔  When CHAT_B will have 1 message with CHAT_A
   ✘  Then CHAT_A and CHAT_B will have a message 'Hey there' with matching delivery timestamps
      Step failed:
      Defined: tests/features/ChatFFI.feature:84:5
      Matched: integration_tests/tests/steps/chat_steps.rs:229:1
      Step panicked. Captured output: assertion failed: `(left == right)`
        left: `1697806717`,
       right: `1697806718`
      Client {
          base_nodes: {},
          blocks: {},
          miners: {},
          ffi_wallets: {},
          wallets: {},
          merge_mining_proxies: {},
          chat_clients: [],
          transactions: {},
          wallet_addresses: {},
          utxos: {},
          output_hash: None,
          pre_image: None,
          wallet_connected_to_base_node: {},
          seed_nodes: [
              "SEED_A",
          ],
          wallet_tx_ids: {},
          errors: [],
          last_imported_tx_ids: [],
          last_merge_miner_response: Null,
      }

Check notice on line 0 in .github

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

33 tests found

There are 33 tests, see "Raw output" for the full list of tests.
Raw output
Scenario: A message is propagated between clients via 3rd party: tests/features/ChatFFI.feature:7:3
Scenario: A message receives a delivery receipt via FFI: tests/features/ChatFFI.feature:78:3
Scenario: A message receives a read receipt via FFI: tests/features/ChatFFI.feature:86:3
Scenario: As a client I want to receive a one-sided transaction: tests/features/WalletFFI.feature:212:5
Scenario: As a client I want to receive contact liveness events: tests/features/WalletFFI.feature:73:5
Scenario: As a client I want to retrieve a list of transactions I have made and received: tests/features/WalletFFI.feature:96:5
Scenario: As a client I want to retrieve the mnemonic word list for a given language: tests/features/WalletFFI.feature:24:5
Scenario: As a client I want to send a one-sided transaction: tests/features/WalletFFI.feature:175:5
Scenario: As a wallet I want to submit a transaction: tests/features/WalletQuery.feature:18:3
Scenario: As a wallet send to a wallet connected to a different base node: tests/features/WalletTransfer.feature:9:3
Scenario: Callback for delivery confirmation received: tests/features/ChatFFI.feature:22:3
Scenario: Callback for new message received: tests/features/ChatFFI.feature:14:3
Scenario: Callback for read confirmation received: tests/features/ChatFFI.feature:31:3
Scenario: Chat shuts down without any errors: tests/features/ChatFFI.feature:63:3
Scenario: Clear out mempool: tests/features/Mempool.feature:46:3
Scenario: Create burn transaction: tests/features/WalletTransactions.feature:411:3
Scenario: Node rolls back reorg on invalid block: tests/features/Reorgs.feature:63:3
Scenario: Pruned mode simple sync: tests/features/Sync.feature:50:3
Scenario: Pruned node should handle burned output: tests/features/Sync.feature:61:3
Scenario: Pruned node should prune outputs: tests/features/Propagation.feature:92:3
Scenario: Reply to message: tests/features/ChatFFI.feature:68:3
Scenario: Simple block sync: tests/features/Sync.feature:26:3
Scenario: Simple propagation: tests/features/Propagation.feature:26:3
Scenario: Simple reorg to stronger chain: tests/features/Reorgs.feature:8:3
Scenario: Simple reorg with burned output: tests/features/Reorgs.feature:33:3
Scenario: Sync burned output: tests/features/Sync.feature:34:3
Scenario: Syncing node while also mining before tip sync: tests/features/Sync.feature:142:5
Scenario: Transactions are propagated through a network: tests/features/Mempool.feature:8:3
Scenario: Verify UTXO and kernel MMR size in header: tests/features/BlockTemplate.feature:8:1
Scenario: Wallet recovery with connected base node staying online: tests/features/WalletRecovery.feature:8:5
Scenario: Wallet sending and receiving one-sided transactions: tests/features/WalletTransactions.feature:8:3
Scenario: When a new node joins the network, it receives all peers: tests/features/Sync.feature:77:3
Scenario: Zero-conf transactions: tests/features/Mempool.feature:124:3