Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove panics from applications #5943

Merged
merged 1 commit into from
Nov 10, 2023

remove panics

bc45e24
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat: remove panics from applications #5943

remove panics
bc45e24
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (Integration tests) failed Nov 10, 2023 in 0s

1 fail, 30 pass in 16m 18s

  2 files  11 suites   16m 18s ⏱️
31 tests 30 ✔️ 0 💤 1
32 runs  31 ✔️ 0 💤 1

Results for commit bc45e24.

Annotations

Check warning on line 0 in /

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

1 out of 2 runs failed: Scenario: Transactions are propagated through a network: tests/features/Mempool.feature:8:3

artifacts/junit-cucumber/cucumber-output-junit.xml [took 31s]
Raw output
Step panicked. Captured output: called `Result::unwrap()` on an `Err` value: transport error  Caused by:     0: error trying to connect: tcp connect error: Connection refused (os error 111)     1: tcp connect error: Connection refused (os error 111)     2: Connection refused (os error 111)
  Scenario: Transactions are propagated through a network
   ✔  Given I have 8 seed nodes
   ✔  When I have a base node SENDER connected to all seed nodes
   ✔  When I have 8 base nodes connected to all seed nodes
   ✔  When I mine a block on SENDER with coinbase CB1
   ✔  When I mine 2 blocks on SENDER
   ✘  Then all nodes are at height 3
      Step failed:
      Defined: tests/features/Mempool.feature:18:5
      Matched: integration_tests/tests/steps/node_steps.rs:166:1
      Step panicked. Captured output: called `Result::unwrap()` on an `Err` value: transport error
      
      Caused by:
          0: error trying to connect: tcp connect error: Connection refused (os error 111)
          1: tcp connect error: Connection refused (os error 111)
          2: Connection refused (os error 111)
      Client {
          base_nodes: {},
          blocks: {},
          miners: {},
          ffi_wallets: {},
          wallets: {},
          merge_mining_proxies: {},
          chat_clients: [],
          transactions: {},
          wallet_addresses: {},
          utxos: {
              "CB1": KeyManagerOutput {
                  version: V0,
                  value: MicroMinotari(
                      18462816327,
                  ),
                  spending_key_id: Managed {
                      branch: "commitment mask",
                      index: 1,
                  },
                  features: OutputFeatures {
                      version: V0,
                      output_type: Coinbase,
                      maturity: 3,
                      coinbase_extra: [],
                      sidechain_feature: None,
                      range_proof_type: BulletProofPlus,
                  },
                  script: TariScript {
                      script: [
                          Nop,
                      ],
                  },
                  covenant: Covenant {
                      tokens: [],
                  },
                  input_data: ExecutionStack {
                      items: [
                          PublicKey(
                              42d5f284a6d0542e43440405974744bc8ae4a58ca77693a6208c1368f04d057a,
                          ),
                      ],
                  },
                  script_private_key_id: Managed {
                      branch: "script key",
                      index: 1,
                  },
                  sender_offset_public_key: 480382131c36f0ad63a12a502d24bbdd870fa208d8a8c7ef766b869c5b0d7400,
                  metadata_signature: CommitmentAndPublicKeySignature {
                      ephemeral_commitment: HomomorphicCommitment(
                          540be85422e29df5d397550625d2c8e576802bacb42abda37e11542d76e09f58,
                      ),
                      ephemeral_pubkey: 26b1f4d0e21fe079360cc19e2bfee3a6b7a27dc3535258b3539a71ae2119347d,
                      u_a: RistrettoSecretKey(***),
                      u_x: RistrettoSecretKey(***),
                      u_y: RistrettoSecretKey(***),
                  },
                  script_lock_height: 0,
                  encrypted_data: EncryptedData {
                      data: [
                          125,
                          34,
                          98,
                          139,
                          28,
                          91,
                          11,
                          75,
                          230,
                          126,
                          21,
                          76,
                          229,
                          103,
                          187,
                          78,
                          113,
                          168,
                          148,
                          180,
                          2,
                          10,
                          247,
                          236,
                          198,
                          241,
                          255,
                          76,
                          105,
                          103,
                          111,
                          143,
                          128,
                          101,
                          120,
                          222,
                          103,
                          78,
                          67,
                          157,
                          227,
                          156,
                          152,
                          70,
                          119,
                          225,
                          183,
                          151,
                          64,
                          158,
                          119,
                          30,
                          102,
                          87,
                          115,
                          201,
                          250,
                          68,
                          169,
                          29,
                          63,
                          102,
                          249,
                          128,
                          17,
                          134,
                          3,
                          172,
                          144,
                          179,
                          2,
                          192,
                          71,
                          38,
                          127,
                          32,
                          120,
                          60,
                          81,
                          70,
                      ],
                  },
                  minimum_value_promise: MicroMinotari(
                      0,
                  ),
              },
          },
          output_hash: None,
          pre_image: None,
          wallet_connected_to_base_node: {},
          seed_nodes: [
              "seed_node_0",
              "seed_node_1",
              "seed_node_2",
              "seed_node_3",
              "seed_node_4",
              "seed_node_5",
              "seed_node_6",
              "seed_node_7",
          ],
          wallet_tx_ids: {},
          errors: [],
          last_imported_tx_ids: [],
          last_merge_miner_response: Null,
      }

Check notice on line 0 in .github

See this annotation in the file changed.

@github-actions github-actions / Test Results (Integration tests)

31 tests found

There are 31 tests, see "Raw output" for the full list of tests.
Raw output
Scenario: A message is propagated between clients via 3rd party: tests/features/ChatFFI.feature:7:3
Scenario: A message receives a delivery receipt via FFI: tests/features/ChatFFI.feature:78:3
Scenario: A message receives a read receipt via FFI: tests/features/ChatFFI.feature:86:3
Scenario: As a client I want to receive a one-sided transaction: tests/features/WalletFFI.feature:212:5
Scenario: As a client I want to receive contact liveness events: tests/features/WalletFFI.feature:73:5
Scenario: As a client I want to retrieve a list of transactions I have made and received: tests/features/WalletFFI.feature:96:5
Scenario: As a client I want to retrieve the mnemonic word list for a given language: tests/features/WalletFFI.feature:24:5
Scenario: As a client I want to send a one-sided transaction: tests/features/WalletFFI.feature:175:5
Scenario: As a wallet I want to submit a transaction: tests/features/WalletQuery.feature:18:3
Scenario: As a wallet send to a wallet connected to a different base node: tests/features/WalletTransfer.feature:9:3
Scenario: Callback for delivery confirmation received: tests/features/ChatFFI.feature:22:3
Scenario: Callback for new message received: tests/features/ChatFFI.feature:14:3
Scenario: Callback for read confirmation received: tests/features/ChatFFI.feature:31:3
Scenario: Chat shuts down without any errors: tests/features/ChatFFI.feature:63:3
Scenario: Clear out mempool: tests/features/Mempool.feature:46:3
Scenario: Create burn transaction: tests/features/WalletTransactions.feature:411:3
Scenario: Fetches all addresses from FFI conversations: tests/features/ChatFFI.feature:95:3
Scenario: Node rolls back reorg on invalid block: tests/features/Reorgs.feature:63:3
Scenario: Reply to message: tests/features/ChatFFI.feature:68:3
Scenario: Simple block sync: tests/features/Sync.feature:26:3
Scenario: Simple propagation: tests/features/Propagation.feature:26:3
Scenario: Simple reorg to stronger chain: tests/features/Reorgs.feature:8:3
Scenario: Simple reorg with burned output: tests/features/Reorgs.feature:33:3
Scenario: Sync burned output: tests/features/Sync.feature:34:3
Scenario: Syncing node while also mining before tip sync: tests/features/Sync.feature:142:5
Scenario: Transactions are propagated through a network: tests/features/Mempool.feature:8:3
Scenario: Verify UTXO and kernel MMR size in header: tests/features/BlockTemplate.feature:8:1
Scenario: Wallet recovery with connected base node staying online: tests/features/WalletRecovery.feature:8:5
Scenario: Wallet sending and receiving one-sided transactions: tests/features/WalletTransactions.feature:8:3
Scenario: When a new node joins the network, it receives all peers: tests/features/Sync.feature:77:3
Scenario: Zero-conf transactions: tests/features/Mempool.feature:124:3