Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix cucumber tests #6080

Closed
wants to merge 1 commit into from
Closed

chore: fix cucumber tests #6080

wants to merge 1 commit into from

Conversation

SWvheerden
Copy link
Collaborator

Description

Fixes cucumber tests in dev

Motivation and Context

Miner should run in non interactive mode during tests

How Has This Been Tested?

tests

@github-actions GitHub Actions
Copy link

Test Results (CI)

1 264 tests   1 264 ✅  11m 23s ⏱️
   39 suites      0 💤
    1 files        0 ❌

Results for commit 5bfc44f.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Jan 16, 2024
@github-actions GitHub Actions
Copy link

Test Results (Integration tests)

29 tests  +29   29 ✅ +29   11m 28s ⏱️ + 11m 28s
11 suites +11    0 💤 ± 0 
 2 files   + 2    0 ❌ ± 0 

Results for commit 5bfc44f. ± Comparison against base commit 3ab7d5d.

hansieodendaal
hansieodendaal reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@hansieodendaal hansieodendaal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the change, however, it seems we still have a reporting issue:

12 scenarios (12 passed)
91 steps (91 passed)
error: test failed, to rerun pass `-p tari_integration_tests --test cucumber`
Error: Process completed with exit code 101.

@SWvheerden
Copy link
Collaborator Author

replacing this with #6074

@SWvheerden SWvheerden closed this Jan 17, 2024
@SWvheerden SWvheerden deleted the sw_fix_cucumber branch January 18, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansieodendaal hansieodendaal hansieodendaal left review comments

Assignees
No one assigned
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SWvheerden @hansieodendaal @ghpbot-tari-project