Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update new block proto to support multiple coinbases #6266

Merged
merged 1 commit into from Apr 15, 2024

Conversation

SWvheerden
Copy link
Collaborator

@SWvheerden SWvheerden commented Apr 10, 2024

Description

This changes the new block proto to allow multiple coinbases

Motivation and Context

Tari supports multiple coinbases and the new block proto only supports a single coinbase.

Breaking Changes

Changes block propagation API

Fixes: #6189

@SWvheerden SWvheerden requested a review from a team as a code owner April 10, 2024 22:47
@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Apr 10, 2024
Copy link

github-actions bot commented Apr 10, 2024

Test Results (CI)

    3 files    120 suites   38m 0s ⏱️
1 277 tests 1 277 ✅ 0 💤 0 ❌
3 823 runs  3 823 ✅ 0 💤 0 ❌

Results for commit 58f4a1e.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Apr 10, 2024

Test Results (Integration tests)

 2 files  11 suites   23m 51s ⏱️
33 tests 32 ✅ 0 💤 1 ❌
34 runs  33 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 58f4a1e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@hansieodendaal hansieodendaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong with the cucumber tests, somehow this change causes many of them to fail.

Other than that the change seems fine.

@SWvheerden SWvheerden merged commit f58ef12 into tari-project:development Apr 15, 2024
14 of 16 checks passed
@SWvheerden SWvheerden deleted the sw_change_new_block branch April 15, 2024 12:13
SWvheerden added a commit to SWvheerden/tari that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix new block proto message for multiple coinbases
3 participants