Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update zeroizing #6323

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

AaronFeickert
Copy link
Collaborator

Description

Cleans up zeroizing.

Motivation and Context

The codebase has included instances of the #[zeroize(drop)] attribute, which is deprecated. This PR replaces the last such instance with the more modern ZeroizeOnDrop derive macro.

How Has This Been Tested?

Existing tests pass.

What process can a PR reviewer use to test or verify this change?

Not much to check here!

Copy link

github-actions bot commented May 6, 2024

Test Results (CI)

    3 files    120 suites   38m 20s ⏱️
1 277 tests 1 277 ✅ 0 💤 0 ❌
3 823 runs  3 823 ✅ 0 💤 0 ❌

Results for commit cda79ae.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 6, 2024
Copy link

github-actions bot commented May 6, 2024

Test Results (Integration tests)

 2 files  11 suites   22m 10s ⏱️
33 tests 32 ✅ 0 💤 1 ❌
34 runs  33 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit cda79ae.

@SWvheerden SWvheerden merged commit d5a4258 into tari-project:development May 7, 2024
14 of 16 checks passed
@AaronFeickert AaronFeickert deleted the zeroize branch May 7, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants