chore: fix build by make ledger type optional #6350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (Integration tests) 2 files + 2 11 suites +11 22m 47s ⏱️ + 22m 47s For more details on these failures, see this check. Results for commit c508682. ± Comparison against base commit 82f0d6a. ♻️ This comment has been updated with latest results. |
ghpbot-tari-project
added
P-acks_required
Test Results (CI) 3 files 112 suites 38m 50s ⏱️ For more details on these failures, see this check. Results for commit c508682. ♻️ This comment has been updated with latest results. |
leet4tari
changed the title
|
Run a build-all in local fork and all seems good. |
ghpbot-tari-project
removed
the
P-reviews_required
ghpbot-tari-project
added
the
P-reviews_required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some packages are build for non std targets. The ledger libraries cannot be built for them. This PR makes sure that ledger stuff is optional for this.