Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(fix): improve cross-compile, add x86_64 target from aarch64 #6352

Conversation

leet4tari
Copy link
Contributor

Description
Move the cross-rs image setup into a shared script, should improve support for cross compiling to Linux
Bump macos build host from 11 to 12
Remove macos install packages that are pre-install, keep a note
Bump protobuf to 26.1 for Android ffis builds with cross-rs
Add the default CFLAGS to build Android ffis with cross-rs
Add a limited dual arch build for docker images with build-dockers- branches

Motivation and Context
Improve general build support, with focus on cross compiling from macos devices
cross-rs pre-built image requires a single script to build from

How Has This Been Tested?
Build locally and in fork

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@leet4tari leet4tari requested a review from a team as a code owner May 23, 2024 13:22
Copy link

Test Results (CI)

    3 files    112 suites   45m 26s ⏱️
1 275 tests 1 274 ✅ 0 💤 1 ❌
3 678 runs  3 677 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 223a278.

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels May 23, 2024
Copy link

Test Results (Integration tests)

 2 files  11 suites   40m 4s ⏱️
33 tests 32 ✅ 0 💤 1 ❌
35 runs  32 ✅ 0 💤 3 ❌

For more details on these failures, see this check.

Results for commit 223a278.

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 24, 2024
@SWvheerden SWvheerden merged commit bc2ac4c into tari-project:development May 24, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants