Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for dune 3.14 #486

Merged
merged 1 commit into from Feb 15, 2024
Merged

Conversation

emillon
Copy link
Collaborator

@emillon emillon commented Feb 12, 2024

dune.3.14.0 adds a loc in its output, see ocaml/dune#9851.

This updates the test output and the constraint.

dune.3.14.0 adds a loc in its output, see ocaml/dune#9851.

This updates the test output and the constraint.
@emillon
Copy link
Collaborator Author

emillon commented Feb 12, 2024

I tried to grep -v to be compatible with both old and new dune, but this is tricky because the line is on stderr, but there are (not pretty) alternatives.

@emillon emillon mentioned this pull request Feb 12, 2024
20 tasks
@Leonidas-from-XIV Leonidas-from-XIV added the no changelog Add this to your PRs to disable the changelog update check label Feb 12, 2024
Copy link
Member

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, given 3.8 and 3.14 support the same OCaml this is close enough.

I assume we'll need add the dune 3.14 constraint in :with-test dependencies on opam-repository as well?

@emillon
Copy link
Collaborator Author

emillon commented Feb 12, 2024

I've already updated the constraints for 2.0.0 here: ocaml/opam-repository#25238

@emillon
Copy link
Collaborator Author

emillon commented Feb 12, 2024

(of course, this PR should only be merged once 3.14 is out)

@vbgl vbgl mentioned this pull request Feb 13, 2024
13 tasks
@Leonidas-from-XIV Leonidas-from-XIV merged commit 2711075 into tarides:main Feb 15, 2024
3 of 4 checks passed
@Leonidas-from-XIV
Copy link
Member

Merging as dune 3.14 has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add this to your PRs to disable the changelog update check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants