Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune_3: 3.13.1 -> 3.14.0 #288510

Merged
merged 3 commits into from
Feb 14, 2024
Merged

dune_3: 3.13.1 -> 3.14.0 #288510

merged 3 commits into from
Feb 14, 2024

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 13, 2024 •
edited

Diff: ocaml/dune@3.13.1...3.14.0

Changelog: https://github.com/ocaml/dune/raw/3.14.0/CHANGES.md

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 馃憤 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from vbgl February 13, 2024 11:39
@vbgl
Copy link
Contributor

vbgl commented Feb 13, 2024

This breaks the tests of dune-release (see: tarides/dune-release#486). It might be a good idea do disable said tests in nixpkgs.

@marsam
Copy link
Contributor Author

marsam commented Feb 13, 2024

This breaks the tests of dune-release

Good catch! I've applied the commit as patch

@ofborg ofborg bot requested a review from sternenseemann February 13, 2024 18:15
@vbgl vbgl merged commit 58a5225 into NixOS:master Feb 14, 2024
23 checks passed
qubitnano pushed a commit to qubitnano/nixpkgs that referenced this pull request Feb 15, 2024
@marsam @qubitnano
dune_3: 3.13.1 -> 3.14.0 (NixOS#288510)
fd91ac7 
* dune_3: 3.13.1 -> 3.14.0

Diff: ocaml/dune@3.13.1...3.14.0

Changelog: https://github.com/ocaml/dune/raw/3.14.0/CHANGES.md

* dune-release: fix tests for dune 3.14

* dune_3: add dune-release as reverse dependency to passthru.tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl vbgl approved these changes

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @vbgl