Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save CLI arguments to the lock file #309

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Save CLI arguments to the lock file #309

merged 1 commit into from
Jun 9, 2022

Conversation

NathanReb
Copy link
Contributor

Fixes #308

github-actions[bot]
github-actions bot reviewed Jun 8, 2022
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
Leonidas-from-XIV
Leonidas-from-XIV reviewed Jun 8, 2022
View reviewed changes
Copy link
Member

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I have some nitpicks/clarifications but I think this is even better than what I envisioned in the original discussion.

lib/lockfile.ml Show resolved Hide resolved
lib/lockfile.ml Outdated Show resolved Hide resolved
Leonidas-from-XIV
Leonidas-from-XIV approved these changes Jun 9, 2022
View reviewed changes
Copy link
Member

@Leonidas-from-XIV Leonidas-from-XIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it :) (After placating the formatter)

@NathanReb
Save CLI arguments to the lock file
60f99fa 
This can be useful for reproducing the exact command
that generated a lock file

Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
@NathanReb NathanReb merged commit e319cfe into tarides:main Jun 9, 2022
NathanReb added a commit to NathanReb/opam-repository that referenced this pull request Jun 9, 2022
@NathanReb
[new release] opam-monorepo (0.3.2)
fa74594 
CHANGES:

### Added

- Add a `--minimal-update` flag to `lock` to generate a lockfile
  with minimum dependency changes from a previous lockfile. (tarides/opam-monorepo#305,
  @NathanReb)
- Add command line options to complement or overwrite `x-opam-monorepo-*`
  fields. (tarides/opam-monorepo#307, @NathanReb)
- Save the `lock` CLI arguments in `x-opam-monorepo-cli-args` when generating a
  lock file. (tarides/opam-monorepo#309, @NathanReb)
@NathanReb NathanReb mentioned this pull request Jun 9, 2022
Merged
@NathanReb NathanReb deleted the add-cli-args-to-lockfile branch June 10, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@Leonidas-from-XIV Leonidas-from-XIV Leonidas-from-XIV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write opam-monorepo invocation into lock file
2 participants
@NathanReb @Leonidas-from-XIV