Fix parsing of lock files with empty duniverses #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanReb
force-pushed
the
fix-empty-duniverse-dirs
branch
from
54c1d84
to
e583ffc
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Leonidas-from-XIV
approved these changes
Jul 13, 2022
|
Looks like my merge of the bugfix created a changelog conflict, sorry about that. |
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Nathan Rebours <nathan.p.rebours@gmail.com>
NathanReb
force-pushed
the
fix-empty-duniverse-dirs
branch
from
6eca09f
to
82026ad
Compare
|
My bad, forgot to merge after the review! Just rebased and fixed the conflict, will merge when it goes green! |
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Nov 21, 2022
CHANGES: ### Added - Add support for specifying remote URLs in `x-opam-monorepo-repositories` (tarides/opam-monorepo#284, tarides/opam-monorepo#317, @Leonidas-from-XIV) ### Fixed - Enable locking of packages with depexts even with uninitialized system package manager state (tarides/opam-monorepo#322, @Leonidas-from-XIV) - Fix a bug where `pull` would crash if the lock file contained no package to vendor (tarides/opam-monorepo#321, @NathanReb) - Display a better error message when the depext command fails when getting the status of the packages (tarides/opam-monorepo#258, tarides/opam-monorepo#323, @RyanGibb, @Julow) - Take `archive-mirrors` from the global opam configuration into account to allow more local caches (tarides/opam-monorepo#337, @hannesm) - Log at WARN level when opam-monorepo chooses a source for a package that doesn't match the package's version (tarides/opam-monorepo#352, @reynir)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #319