Disable filtering of available packages for availability of their depexts #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exts OPAM by default filters out packages for which the system on which it is running does not have the depexts. Which is nice in theory but when building a lockfile we want all packages to be available. The problem here is that some configurations do not have a queryable package list, e.g. when using Docker containers the package list might have been deleted to save on space in the container, thus `available_packages` would be just a subset and missing packages, despite these existing in the OPAM repositories.
Leonidas-from-XIV
force-pushed
the
disable-depext-filtering
branch
from
5d39d89
to
a994fbb
Compare
NathanReb
approved these changes
Jul 13, 2022
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Nov 21, 2022
CHANGES: ### Added - Add support for specifying remote URLs in `x-opam-monorepo-repositories` (tarides/opam-monorepo#284, tarides/opam-monorepo#317, @Leonidas-from-XIV) ### Fixed - Enable locking of packages with depexts even with uninitialized system package manager state (tarides/opam-monorepo#322, @Leonidas-from-XIV) - Fix a bug where `pull` would crash if the lock file contained no package to vendor (tarides/opam-monorepo#321, @NathanReb) - Display a better error message when the depext command fails when getting the status of the packages (tarides/opam-monorepo#258, tarides/opam-monorepo#323, @RyanGibb, @Julow) - Take `archive-mirrors` from the global opam configuration into account to allow more local caches (tarides/opam-monorepo#337, @hannesm) - Log at WARN level when opam-monorepo chooses a source for a package that doesn't match the package's version (tarides/opam-monorepo#352, @reynir)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPAM by default filters out packages for which the system on which it is running does not have the depexts. Which is nice in theory but when building a lockfile we want all packages to be available.
The problem here is that some configurations do not have a queryable package list, e.g. when using Docker containers the package list might have been deleted to save on space in the container, thus
available_packageswould be just a subset and missing packages, despite these existing in the OPAM repositories.This is the reason why on the Tezos CI it needs
apk updatebecause if the package list is missing it will just silently exclude a lot of the necessaryconf-*packages. I tested it locally in a Docker container built in the same way as Tezos where I could reproduce the issue and disabling this in the config makes it work out of the box, without the need for workarounds.