Skip to content
This repository has been archived by the owner on Jan 25, 2024. It is now read-only.

Proposing a fix for issues#16 #22

Merged

Conversation

hussaintamboli
Copy link
Contributor

@hussaintamboli hussaintamboli commented Mar 21, 2018

I have been struggling with issues where excel converts big numbers to scientific format. e.g. 200420340204032403204 into 2.0042E+20. And it's really painful to convert it back to original textual format.

I need an option in ExcelResponse to control this behaviour.

@codecov
Copy link

codecov bot commented Mar 21, 2018

Codecov Report

Merging #22 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage    96.7%   96.73%   +0.03%     
==========================================
  Files           1        1              
  Lines          91       92       +1     
  Branches       20       20              
==========================================
+ Hits           88       89       +1     
  Misses          1        1              
  Partials        2        2
Impacted Files Coverage Δ
excel_response/response.py 96.73% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b532d98...6f5d524. Read the comment docs.

@tarkatronic
Copy link
Owner

@hussaintamboli Thank you for your contribution; this does look like a good fix! Can you add a test just to verify the behavior with guess_types turned on and off? With that, it looks like it will be good to merge!

@tarkatronic tarkatronic merged commit 2e9f89b into tarkatronic:master Mar 28, 2018
@tarkatronic
Copy link
Owner

Thank you! I will try to get a new version out ASAP with this fix.

@hussaintamboli hussaintamboli deleted the issues-16-control-guess-types branch April 2, 2018 02:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants