Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Code Expression ✨ #542

Merged
merged 5 commits into from Nov 4, 2021
Merged

Refactor Code Expression ✨ #542

merged 5 commits into from Nov 4, 2021

Conversation

yezz123
Copy link
Contributor

@yezz123 yezz123 commented Nov 4, 2021

Before submitting your pull request, make sure the following is done.

  • Fork the repository and create your branch from master so that it can be merged easily.
  • Update changelogs/next.md with your change (include reference to the issue & this PR).
  • Make sure all of the significant new logic is covered by tests.
  • Make sure all quality checks are green (Gazr specification).

Learn more about contributing

abusi
abusi reviewed Nov 4, 2021
View reviewed changes
Copy link
Contributor

@abusi abusi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool changes, thank you for contributing. It'll help the project stay 'fresh' :)

tests/unit/test_introspection.py Outdated Show resolved Hide resolved
@yezz123 yezz123 requested a review from abusi November 4, 2021 14:34
@abusi abusi merged commit c9fc4cb into tartiflette:master Nov 4, 2021
@abusi
Copy link
Contributor

abusi commented Nov 4, 2021

Thanks @yezz123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abusi abusi Awaiting requested review from abusi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yezz123 @abusi