Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Env variables #16

Merged
merged 4 commits into from

2 participants

@lightsofapollo

See lightsofapollo@e9d9703 for a better view of the code changes without the vendor stuffs

@jonasfj
Owner

If there is an appealing reason not to use a dictionary for environment variables, then at least add some docs to the README so we know how they should be given.
From what I can see it's

 env: ['MYVARIABLE=\'mystring\'', 'MYVARIABLE2=\'mystring2\'']

But doesn't this become problematic when my string contains things like " or ', I'm not a fan of double escaping... Especially not considering that you might have to escape an extra time in JSON :)

@lightsofapollo

@jonasfj You don't need to argue very hard to get objects to win... I greatly prefer these I just wish we didn't have to wrap docker... I will bug someone to see why they do this.

@lightsofapollo lightsofapollo merged commit 2086fd7 into taskcluster:master
@lightsofapollo lightsofapollo deleted the lightsofapollo:env-variables branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 5, 2014
  1. @lightsofapollo
  2. @lightsofapollo

    vbump live logging lib

    lightsofapollo authored
  3. @lightsofapollo
Commits on Mar 6, 2014
  1. @lightsofapollo
Something went wrong with that request. Please try again.