This repository has been archived by the owner on May 9, 2020. It is now read-only.
Retry npm install during deployment process #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are times where there might be an issue contact npm where a retry would help. This is specifically useful in the case where there is a connection reset.
|
Taskcluster graph created. https://tools.taskcluster.net/task-graph-inspector/#h4vTlvodRDiottuS0SafAw |
|
@gregarndt should we merge this in now? Thanks! |
| npm install --production | ||
|
|
||
| retry_count=0 | ||
| max_retries=5 |
There was a problem hiding this comment.
should we bump this a little higher just to be super-safe?
|
From irc: |
imbstack
pushed a commit
to taskcluster/taskcluster
that referenced
this pull request
May 5, 2020
From irc: ``` 17:56 <pmoore> ah should i merge taskcluster/docker-worker#235 ? 18:00 <garndt> Feel free to merge it ```
imbstack
pushed a commit
to taskcluster/taskcluster
that referenced
this pull request
May 7, 2020
From irc: ``` 17:56 <pmoore> ah should i merge taskcluster/docker-worker#235 ? 18:00 <garndt> Feel free to merge it ```
imbstack
pushed a commit
to taskcluster/taskcluster
that referenced
this pull request
May 7, 2020
From irc: ``` 17:56 <pmoore> ah should i merge taskcluster/docker-worker#235 ? 18:00 <garndt> Feel free to merge it ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are times where there might be an issue contact npm where a retry
would help. This is specifically useful in the case where there is a
connection reset.