This repository has been archived by the owner on Apr 13, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Restructure amqp setup for new treeherder actions #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightsofapollo
force-pushed
the
retrigger-th
branch
2 times, most recently
from
March 5, 2015 23:19
30c3aa9
to
c96caa6
Compare
When treeherder emits an action we process retriggers for the configured build system type. The job is mapped to task then the task to a task graph and the node in that graph is duplicated (and dependant nodes in failure cases). - Adds optional error logging when kue tasks fail - Adds new "retrigger" exchange emitted when retriggers complete successfully
lightsofapollo
force-pushed
the
retrigger-th
branch
from
March 6, 2015 17:20
c96caa6
to
0ed4226
Compare
@rail this is a much bigger one if your interested... this handles retrigger logic... I am going to add the circle CI tests prior to landing this one way or another. |
lightsofapollo
force-pushed
the
retrigger-th
branch
3 times, most recently
from
March 8, 2015 07:26
c393f04
to
1b55d0e
Compare
lightsofapollo
force-pushed
the
retrigger-th
branch
from
March 8, 2015 19:50
31f5a1f
to
ae0949c
Compare
lightsofapollo
force-pushed
the
retrigger-th
branch
from
March 9, 2015 07:57
80c13f6
to
1ba1eed
Compare
lightsofapollo
added a commit
that referenced
this pull request
Mar 9, 2015
Restructure amqp setup for new treeherder actions
let indexes = this.prototype.indexes; | ||
|
||
assert(id, 'Must define .id'); | ||
assert(schema, 'Must define schema'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use Joi instead of asserts to follow the common pattern?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.