This repository has been archived by the owner on Jan 5, 2019. It is now read-only.
Allow clock skew in temp creds #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should document that the auth service adjusts for clock skew, so that client libraries, or callers of client libraries, don't also apply clock skew. And we should probably apply the same clock skew to hawk authentication (currently we use 15 mins, so this should probably be reduced to 5 mins and documented too). |
petemoore
added a commit
to taskcluster/taskcluster-client-java
that referenced
this pull request
Dec 20, 2017
petemoore
added a commit
to taskcluster/taskcluster-client-go
that referenced
this pull request
Dec 20, 2017
This is now taken care of in the auth service directly: taskcluster/taskcluster-auth#117
petemoore
added a commit
to taskcluster/taskcluster-client
that referenced
this pull request
Dec 20, 2017
This is now taken care of in the auth service directly: taskcluster/taskcluster-auth#117
petemoore
added a commit
to taskcluster/taskcluster-client.py
that referenced
this pull request
Dec 20, 2017
This is now taken care of in the auth service directly: taskcluster/taskcluster-auth#117
petemoore
added a commit
to taskcluster/taskcluster-docs
that referenced
this pull request
Dec 20, 2017
This is now taken care of in the auth service directly: taskcluster/taskcluster-auth#117
petemoore
added a commit
to taskcluster/taskcluster-client-web
that referenced
this pull request
Dec 20, 2017
This is now taken care of in the auth service directly: taskcluster/taskcluster-auth#117
djmitche
approved these changes
Dec 20, 2017
eliperelman
pushed a commit
to taskcluster/taskcluster-client-web
that referenced
this pull request
Jan 9, 2018
This is now taken care of in the auth service directly: taskcluster/taskcluster-auth#117
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
credits to @petemoore for finding this...