Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

after update to 1.51.0,raise ReferenceError: updateParentDepsIfNeeded is not defined #837

Closed
michael-land opened this issue Oct 28, 2021 · 5 comments · Fixed by #843
Closed

after update to 1.51.0,raise ReferenceError: updateParentDepsIfNeeded is not defined #837

michael-land opened this issue Oct 28, 2021 · 5 comments · Fixed by #843
Labels
released

Comments

@michael-land
Copy link

michael-land commented Oct 28, 2021 •
edited
Loading

not sure why this happens. 1.50.7 works fine.

the project using monorepo pattern with yarn v3

ReferenceError: updateParentDepsIfNeeded is not defined
    at eval (lodash.templateSources[0]:9:11)
    at loadScripts (/Users/.../node_modules/bullmq/dist/commands/index.js:64:47)
    at async Object.exports.load (/Users/.../node_modules/bullmq/dist/commands/index.js:24:21)
    at async RedisConnection.init (/Users/.../node_modules/bullmq/dist/classes/redis-connection.js:98:9)
ReferenceError: updateParentDepsIfNeeded is not defined
    at eval (lodash.templateSources[0]:9:11)
    at loadScripts (/Users/.../node_modules/bullmq/dist/commands/index.js:64:47)
    at async Object.exports.load (/Users/.../node_modules/bullmq/dist/commands/index.js:24:21)
    at async RedisConnection.init (/Users/.../node_modules/bullmq/dist/classes/redis-connection.js:98:9)
@michael-land
Copy link
Author

michael-land commented Oct 28, 2021 •
edited
Loading

probably because command/includes not copied over with this glob

package.json

"copylua": "copyfiles -f ./src/commands/*.lua ./dist/commands",

@lucasavila00 lucasavila00 mentioned this issue Oct 28, 2021
Closed
@roggervalf roggervalf mentioned this issue Oct 29, 2021
Merged
roggervalf added a commit that referenced this issue Oct 29, 2021
@roggervalf
fix(commands): copy includes lua scripts (#843) fixes #837
cab33e0
@roggervalf
Copy link
Collaborator

Thank you @xiaoyu-tamu for reporting this issue, should be fixed now

github-actions bot pushed a commit that referenced this issue Oct 29, 2021
@semantic-release-bot
chore(release): 1.51.1 [skip ci]
1c99cc7 
## [1.51.1](v1.51.0...v1.51.1) (2021-10-29)

### Bug Fixes

* **commands:** copy includes lua scripts ([#843](#843)) fixes [#837](#837) ([cab33e0](cab33e0))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.51.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@prescience-data
Copy link

I am on 1.51.1 and still receiving this error.

 2021-10-29 04:53:18.069  ERROR
 [
   'Error acquiring job for worker "fc97cf34-8e61-49f9-9e40-6cb7330c92df":',
   ReferenceError: updateParentDepsIfNeeded is not defined
       at eval (lodash.templateSources[1]:9:11)
       at loadScripts (/home/node_modules/bullmq/dist/commands/index.js:64:47)
       at async Object.exports.load (/home/node_modules/bullmq/dist/commands/index.js:24:21)
       at async RedisConnection.init (/home/node_modules/bullmq/dist/classes/redis-connection.js:98:9),
   0,
   0
 ]

@prescience-data prescience-data mentioned this issue Oct 29, 2021
Closed
@michael-land
Copy link
Author

it's working for me. try remove node_modules and reinstall. it's possible that you have two versions of bullmq mixed up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(commands): copy includes lua scripts taskforcesh/bullmq
3 participants
@roggervalf @michael-land @prescience-data